Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed fixes #86

Merged
merged 2 commits into from
May 26, 2018
Merged

Speed fixes #86

merged 2 commits into from
May 26, 2018

Conversation

mz-pdm
Copy link
Contributor

@mz-pdm mz-pdm commented May 25, 2018

There are some typos in the code that can cause loss of speed data in the output files.

@pcolby pcolby self-requested a review May 25, 2018 23:55
pcolby added a commit that referenced this pull request May 26, 2018
@pcolby
Copy link
Owner

pcolby commented May 26, 2018

Thanks @mz-pdm! 👍

The change looks good, but broke some tests. I've pulled to a branch and updated the tests (9f699ac)... will let the CI systems do their thing (will take a few hours for all tested platforms), then merge to master 😄

Thanks again.

Copy link
Owner

@pcolby pcolby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't believe that HRM bug had been there for four years!

@pcolby pcolby merged commit 957e4c4 into pcolby:master May 26, 2018
pcolby added a commit that referenced this pull request May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants