Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: switch lim colors to blk/org from yel/yel #600

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Mar 19, 2024

Description

Switch the limit indicator colors to something more visible for the positioner widgets.

Motivation and Context

Many justified complaints about yellow -> brighter yellow being impossible to see for many users/screens

How Has This Been Tested?

Interactively only

Where Has This Been Documented?

slack thread, so far, release notes later

Screenshots (if appropriate):

old:
old_lims
new:
new_lims
image

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Code has been checked for threading issues (no blocking tasks in GUI thread)
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@ZLLentz
Copy link
Member Author

ZLLentz commented Mar 19, 2024

tests broken by some upstream library change, will untangle in a separate PR

@ZLLentz ZLLentz marked this pull request as ready for review March 19, 2024 22:14
patoppermann
patoppermann previously approved these changes Mar 20, 2024
Copy link

@patoppermann patoppermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice of colors.

@ZLLentz
Copy link
Member Author

ZLLentz commented Mar 20, 2024

I'm going to merge this and apply it to dev_conda, then come back later for the more general typhos build issues

@ZLLentz ZLLentz merged commit 05dd328 into pcdshub:master Mar 20, 2024
3 of 9 checks passed
@ZLLentz ZLLentz deleted the enh_lim_colors branch March 20, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants