Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL/DOC: release notes for v3.1.0, make release script run on windows #598

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Dec 6, 2023

Description

  • Compile release notes for v3.1.0
  • Adjust the release notes script to run on my local windows machine by forcing a sane encoding

Motivation and Context

  • Let's make a quick tag for the updates merged today so they'll be available on pypi/conda-forge soon
  • I'm currently working locally for once (planned power outage), and windows does not have a sane encoding default

How Has This Been Tested?

  • Interactively only

Where Has This Been Documented?

  • This is docs

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Code has been checked for threading issues (no blocking tasks in GUI thread)
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@ZLLentz ZLLentz requested a review from tangkong December 6, 2023 01:08
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🏷️

@ZLLentz ZLLentz merged commit 75d3e3c into pcdshub:master Dec 6, 2023
8 of 9 checks passed
@ZLLentz ZLLentz deleted the rel_v3.1.0 branch December 6, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants