Merge pull request #626 from aberges-SLAC/update_children_fix

ENH: Zach's impressive 11 char fix to _update_children
pcdshub · Jan 30, 2025 · 90b568b · 90b568b
2 parents 3c1daa6 + 8f7837f
commit 90b568b
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/...rce/upcoming_release_notes/625-fix_add_device_behavior_with_custom_displays.rst b/...rce/upcoming_release_notes/625-fix_add_device_behavior_with_custom_displays.rst
@@ -0,0 +1,23 @@
+625 fix add_device behavior with custom displays
+#################
+
+API Breaks
+----------
+- N/A
+
+Features
+--------
+- Allows custom displays with "add_device" methods to hook typhos correctly
+
+Bugfixes
+--------
+- N/A
+
+Maintenance
+-----------
+- N/A
+
+Contributors
+------------
+- ZLLentz
+- aberges-SLAC
diff --git a/typhos/display.py b/typhos/display.py
@@ -1467,7 +1467,7 @@ def _update_children(self):
         designer = display.findChildren(widgets.TyphosDesignerMixin) or []
         bases = display.findChildren(utils.TyphosBase) or []
 
-        for widget in set(bases + designer):
+        for widget in set(bases + designer + [display]):
             if device and hasattr(widget, 'add_device'):
                 widget.add_device(device)