Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF/FIX: fix py39-lxml + move packages to variables #9

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Sep 28, 2023

  • Last-minute touch-ups after I found that py39-lxml was removed without notice from the Beckhoff 13 stable package server
  • So, in my opinion, the best path forward here is enabling the OpenBSD repositories as a fallback for when TwinCAT repos don't have the packages
    • This is done by removing a stub file that Beckhoff installs specifically disabling the OpenBSD repo
  • Additionally, this moves packages to be variables instead of baked into the playbook
    • This just seems to be good or at least better practice
    • I think that "normal" playbooks may have these dependencies baked into individual roles
  • Roles are not really in use in this repository - and that may be something to follow up on for actual production deployments
  • Adds optional step to install pip packages (and then subsequently remove pip)

@klauer klauer linked an issue Sep 28, 2023 that may be closed by this pull request
Copy link

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Diff seems to match the intention, but I'm no expert. Glad we were able to get lxml elsewhere. I think this ends up needing to be "Python Dev", with an eventual promotion to "Python Library"

@klauer klauer merged commit 5d6c4cb into pcdshub:master Sep 28, 2023
1 check passed
@klauer klauer deleted the fix_py39-lxml branch September 28, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py39-lxml removed from Beckhoff TC/BSD 13 stable package server
2 participants