Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: switch from host_inventory.yaml to LCLS-style directory structure #8

Merged
merged 5 commits into from
Sep 8, 2023
Merged

REF: switch from host_inventory.yaml to LCLS-style directory structure #8

merged 5 commits into from
Sep 8, 2023

Conversation

klauer
Copy link
Contributor

@klauer klauer commented Jul 25, 2023

Context

  • Restructuring host_inventory.yaml to LCLS-style directory structure
  • This should ease integration down the line
  • Makes it easier to specify different roles and configuration for individual PLCs
  • This may be excessive for "single PLC ansible example repo" - but we're looking forward here

@klauer klauer marked this pull request as ready for review September 8, 2023 18:37
@klauer
Copy link
Contributor Author

klauer commented Sep 8, 2023

Let's get this merged before our hackathon

tangkong
tangkong approved these changes Sep 8, 2023
View reviewed changes
group_vars/tcbsd_plcs/vars.yml
@@ -0,0 +1,36 @@
---
ansible_user: Administrator
ansible_ssh_private_key_file: /Users/klauer/Repos/twincat-bsd-ansible-testing/tcbsd_key_rsa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this (and the rest of the file, for that matter) get templated / filled in some way? Or is this file just meant to be an example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good catch - just an example (still probably something I should have changed before asking for a review to be honest...)

ZLLentz
ZLLentz approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough experience/knowledge to understand the significance of this change but it seems good

@klauer klauer merged commit 41aef05 into pcdshub:master Sep 8, 2023
1 check passed
@klauer klauer deleted the ref_organization branch September 8, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangkong tangkong tangkong approved these changes

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klauer @ZLLentz @tangkong