Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: add git safe directory for centrally deployed git repos #26

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Apr 11, 2024

Description

  • If it has not already been done, add the ansible root directory as a safe directory for the purposes of git when we need to use git to check the version number.

Motivation and Context

  • After running a plc setup, we are supposed to document the results.
  • Providing some version information to the user at exit is really helpful for making it possible to complete this step.
  • "git describe" is the simplest way to get this information
  • All git commands refuse to run for shared directories unless safe.directory has an entry for the cloned git repo path.

How Has This Been Tested?

  • Interactively only, as me

Where Has This Been Documented?

  • Only here and in jira

Pre-merge checklist

@ZLLentz ZLLentz requested a review from tangkong April 11, 2024 18:10
Copy link

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZLLentz ZLLentz merged commit 2c2afc3 into pcdshub:master Apr 11, 2024
1 check passed
@ZLLentz ZLLentz deleted the bug_git_safedir branch April 11, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants