Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fixes for inventory management bugs #25

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Apr 11, 2024

Description

  • Fix a bug where empty string or arbitrary command-line arguments would be used instead of the hostname during setup
  • Fix a bug where empty host groups could not be added to
  • Make sure this script will still work if we start using sub-element configuration in the inventory
  • Make the type hinting for the _Inventory alias very verbose to help me fix the empty host groups

Motivation and Context

  • The setup scripts are intended to add your PLC to the ansible inventory semi-automatically, only prompting for picking a group.
  • Currently, this breaks down in several ways. See https://jira.slac.stanford.edu/browse/ECS-4976
  • Continue using yaml directly rather than use the ansible config API because ansible says that their config file API should be considered internal/not public/not stable

How Has This Been Tested?

Interactively by adding hostnames to empty groups

Where Has This Been Documented?

Here + jira

Pre-merge checklist

@ZLLentz ZLLentz requested a review from tangkong April 11, 2024 16:58
Copy link

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Still wrapping my head around all the bugs but this looks solid

@ZLLentz ZLLentz merged commit 34a8a8c into pcdshub:master Apr 11, 2024
1 check passed
@ZLLentz ZLLentz deleted the bug_inventory branch April 11, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants