ENH: option to dynamically set the AMS net id at runtime #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a (default: true) option for setting the ams net id dynamically at runtime based on the current IP address.
This remains (default: false) for the vms for backcompat.
Built on top of #17 and includes the commits from that PR
Motivation and Context
An issue was brought up in the review that it'd be great to use these scripts to help us avoid ams net id collisions. This also goes a step further and helps us never need to manually set an ams net id ever again.
How Has This Been Tested?
Interactively I verified that this pulled the correct ams net id for the test plcs and that the non-dynamic mode could still be used.
Where Has This Been Documented?
Added a small note to https://confluence.slac.stanford.edu/display/PCDS/TcBSD+Ansible+Workflows
Pre-merge checklist