ENH: more steps, full remote setup from factory #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
previously approved these changes
Feb 13, 2024
group_vars/tcbsd_vms/vars.yml
Outdated
| use_psntp: false | ||
|
|
||
| # set static IP on x000 (mac id 2) | ||
| x000_static: |
There was a problem hiding this comment.
I suppose this would need to be filled, but it doesn't break anything now because we don't use the VMs?
There was a problem hiding this comment.
The intent here is that it is set to empty string, but maybe this is fundamentally unclear and I should add boolean switches for using the setting
There was a problem hiding this comment.
I'll do this clarity change and then I think this PR is done after that
tcbsd-provision-playbook.yaml
Outdated
| @@ -44,8 +106,8 @@ | |||
| ansible.builtin.pip: | |||
| name: "{{ tc_install_pip_packages }}" | |||
|
|
|||
| - name: Install pip | |||
| # Packages only available via pip will be installed after this | |||
| - name: Unstall pip | |||
There was a problem hiding this comment.
I'm pretty upset at myself for unstall vs uninstall lol
tangkong
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is everything we need for people to be able to run the script reliably once and get all the settings for a PLC program + IOC to be able to work.
It's possible that we'll also need a plc restart step, I'll add one after the next "from factory" go if needed.
Main additions:
Misc: