Merge pull request #17 from ZLLentz/fix_dry_run

FIX: dry run issues with config mode check
pcdshub · Mar 18, 2024 · 6d1f0e0 · 6d1f0e0
2 parents fe0515d + 9519739
commit 6d1f0e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -21,6 +21,7 @@
 
 ## Pre-merge checklist
 - [ ] Code works interactively
+- [ ] Code works interactively in dry_run mode
 - [ ] Code contains descriptive docstrings, including context and API
 - [ ] Pre-commit passes on GitHub Actions
 - [ ] Documentation under https://confluence.slac.stanford.edu/display/PCDS/TcBSD has been updated appropriately
diff --git a/tcbsd-provision-playbook.yaml b/tcbsd-provision-playbook.yaml
@@ -12,6 +12,7 @@
         cmd: TcSysExe.exe --mode
 
     - name: Assert that PLC is in CONFIG mode
+      when: not ansible_check_mode
       ansible.builtin.assert:
         that: "{{ 'CONFIG' in plc_mode.stdout }}"
         fail_msg: "PLC is in RUN mode! Abort!"