Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: add top level tree to main window #69

Merged
merged 11 commits into from
Aug 1, 2024

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Jul 26, 2024

Description

  • Adds top-level tree to main window
  • Adds icons to the TreeModel
  • Adds fill_uuid method to TreeModel, which grabs data from client if possible
  • Adds context menu on tree view for accessing custom actions. Currently only has an open-page action, but later could include more
  • Adds a couple tests

Motivation and Context

closes #44

How Has This Been Tested?

Interactively. Am I getting lazy with gui tests? Do I just fear them? Is it a superposition? 🤔

I added a couple tests, gui testing can be finicky

Where Has This Been Documented?

This PR.

image

Pre-merge checklist

  • Code works interactively
  • Code follows the style guide
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 on the changes here, again I don't have much to suggest.

@tangkong
Copy link
Contributor Author

I'll merge this tomorrow morning, if there are no further comments or reviews.

@tangkong tangkong merged commit dc7ded7 into pcdshub:master Aug 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants