-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: Basic GUI elements, DataWidget pages #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangkong
force-pushed
the
gui_main_window
branch
from
June 21, 2024 19:47
f6ad79d
to
62ab672
Compare
tangkong
changed the title
GUI / WIP: Basic GUI elements, DataWidget pages
GUI: Basic GUI elements, DataWidget pages
Jun 26, 2024
shilorigins
reviewed
Jul 1, 2024
shilorigins
reviewed
Jul 1, 2024
shilorigins
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataWidget
andNameDescTagsWidget
, components for making widgets that communicate with dataclassesEntryItem
andRootTree
for representing Entry dataclasses in a tree viewTo-Do, possibly in followup issues:
Motivation and Context
We need a framework to make a GUI.
I lifted most of this from ATEF, and as such we should be free to challenge any of the things we've built here. We've found it quite useful, and I think it can be similarly useful here. There should definitely be a keen eye taken to these. While we've proven they work, they shouldn't be taken as gospel. I say this partially for the review of this PR, but maybe mostly for future efforts that use these components.
The
RootModel
is very incomplete, and client interactions still need to be fleshed out. I can see a world where we create the client on GUI startup and have some helper for fetching it, rather than passing it to every widget instance. There was also an intent to make the data model loading lazy, and theRootModel
is where this would manifest. But this PR is already long enough.If I ever have to vendor the DataWidget / QDataclassBridge stuff again I'm going to upstream it into pcdsutils.
How Has This Been Tested?
Added some tests.
Where Has This Been Documented?
This PR
Pre-merge checklist
docs/pre-release-notes.sh
and created a pre-release documentation page