-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding base class for HxrDiffractometer #1274
Conversation
I think the lakeshore file was removed a while ago. Your branch is a bit out of date, we should rebase or merge the master into this branch. Let me know if you need help with this |
I think the lakeshore was never part of pcdsdevices, there's a super old issue to add one and I can't find any point in time where we completed the task (#826). The file is new to me at least. Probably these should be split into two PRs, or if that is prohibitive we can do a 2-in-1 with some updated documentation. |
We sorted this out offline, Christian will be splitting this up into two PRs, and we rebased this one 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the mapping and add the pre-release notes etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this still needs pre-release notes
@ZLLentz done! |
|
||
Contributors | ||
------------ | ||
- N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You gotta credit yourself tho, you made the thing
Description
Adding base class for HxrDiffractometer, this class will ask the user to input the prefix HXR:GON:MMS: and it has the motion stages hardcoded.
Motivation and Context
This change allows us to control the hxr diffractometer stages using python.
How Has This Been Tested?
I was able to connect to the PVs and I have done motion test to the stages.
Where Has This Been Documented?
Pre-merge checklist