Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding base class for HxrDiffractometer #1274

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Conversation

c-tsoi
Copy link
Contributor

@c-tsoi c-tsoi commented Aug 20, 2024

Description

Adding base class for HxrDiffractometer, this class will ask the user to input the prefix HXR:GON:MMS: and it has the motion stages hardcoded.

Motivation and Context

This change allows us to control the hxr diffractometer stages using python.

How Has This Been Tested?

I was able to connect to the PVs and I have done motion test to the stages.

Where Has This Been Documented?

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@c-tsoi c-tsoi requested a review from vespos August 20, 2024 16:41
@c-tsoi c-tsoi marked this pull request as draft August 20, 2024 16:41
@c-tsoi c-tsoi marked this pull request as ready for review August 23, 2024 20:48
@tangkong
Copy link
Contributor

I think the lakeshore file was removed a while ago. Your branch is a bit out of date, we should rebase or merge the master into this branch.

Let me know if you need help with this

@ZLLentz
Copy link
Member

ZLLentz commented Aug 26, 2024

I think the lakeshore was never part of pcdsdevices, there's a super old issue to add one and I can't find any point in time where we completed the task (#826). The file is new to me at least. Probably these should be split into two PRs, or if that is prohibitive we can do a 2-in-1 with some updated documentation.

@tangkong
Copy link
Contributor

We sorted this out offline, Christian will be splitting this up into two PRs, and we rebased this one 👍

Copy link
Contributor

@vespos vespos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the mapping and add the pre-release notes etc

pcdsdevices/gon.py Outdated Show resolved Hide resolved
vespos
vespos previously approved these changes Sep 30, 2024
Copy link
Contributor

@vespos vespos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this still needs pre-release notes

@c-tsoi
Copy link
Contributor Author

c-tsoi commented Oct 1, 2024

I think this still needs pre-release notes

@ZLLentz done!


Contributors
------------
- N/A
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gotta credit yourself tho, you made the thing

@ZLLentz ZLLentz merged commit 50e9f4b into pcdshub:master Oct 1, 2024
11 checks passed
@ZLLentz ZLLentz mentioned this pull request Oct 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants