Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: PPM Safe Limit Stopping #35

Closed
wants to merge 2 commits into from
Closed

FIX: PPM Safe Limit Stopping #35

wants to merge 2 commits into from

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Apr 22, 2020

closes #31

@ZLLentz
Copy link
Member Author

ZLLentz commented Apr 22, 2020 •
edited
Loading

I'm actually not sure if this is the correct thing to do... it is possible that we need the lower deceleration and we'll have to trust that the absolute encoder is well-configured. Changing parameters like this without the physical hardware to test on is a little silly. I'm going to let this one sit for a bit.

@ZLLentz ZLLentz marked this pull request as draft April 22, 2020 23:40
@ZLLentz
Copy link
Member Author

ZLLentz commented Dec 15, 2020

Closing as this is probably the wrong approach

@ZLLentz ZLLentz closed this Dec 15, 2020
@ZLLentz ZLLentz deleted the ppm-speed branch December 24, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PPM Velocity, Acceleration
1 participant
@ZLLentz