Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: LCLS-General place holder not set #55

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented May 8, 2024

Description

Went to release this project and got:

ERROR:pytmc.bin.db:Duplicate records encountered:
    $(PREFIX)LCLSGeneral:GlobalLogTrickleTrip_RBV (2)
    $(PREFIX)LCLSGeneral:LogHost (2)
    $(PREFIX)LCLSGeneral:LogHost_RBV (2)
    $(PREFIX)LCLSGeneral:LogMessageCount_RBV (2)
    $(PREFIX)LCLSGeneral:LogPort (2)
    $(PREFIX)LCLSGeneral:LogPort_RBV (2)

Found place holder for LCLSGeneral set to *, set to 2.8.2, same as project.

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@nrwslac nrwslac requested review from ZLLentz and joshc-slac May 8, 2024 22:39
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also check that the generated IOC no longer had duplicated records?

@nrwslac
Copy link
Contributor Author

nrwslac commented May 8, 2024

Did you also check that the generated IOC no longer had duplicated records?

It doesn't appear to throw any complaints when I build off my branch. I for some reason think the tc-release behavior is different. I'll merge now and check. it works.

@nrwslac nrwslac merged commit 018042c into pcdshub:master May 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants