Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrading twincat motion library to fix the AL1K4 issue #97

Merged
merged 1 commit into from
Sep 13, 2023
Merged

upgrading twincat motion library to fix the AL1K4 issue #97

merged 1 commit into from
Sep 13, 2023

Conversation

tongju12
Copy link
Contributor

TMO found some issues when scientists try to move AL1K4 and LI1K4

Could not move those in state mover but can move them by motors

Motivation and Context

Scientists can move AL1K4 and LI1K4 from state mover instead of motors

How Has This Been Tested?

Yes, Scientists already moved those.

Where Has This Been Documented?

pcdshub/lcls-twincat-motion#197

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

ZLLentz
ZLLentz approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tongju12 tongju12 merged commit 71219d9 into pcdshub:master Sep 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tongju12 @ZLLentz