Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Flow Meter for Imagers IM3/4/5/6K4 #94

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

nrwslac
Copy link
Contributor

@nrwslac nrwslac commented Aug 22, 2023

Description

  • LCLS-General 2.9.0
  • lcls2-cc-lib 2.1.0
  • implement flow meters for im3/4/5/6k4

Motivation and Context

New hardware installed FD-Q20C Keyence flow meters.

How Has This Been Tested?

  • running branch on lcls-plc-tmo-motion
  • IOC rebuilt and test:
  • nrw@tmo-control:~$ camonitor IM4K4:PPM:FWM:VAL_RBV
    IM4K4:PPM:FWM:VAL_RBV 2023-08-22 10:21:48.375937 1.80366
    IM4K4:PPM:FWM:VAL_RBV 2023-08-22 10:21:49.375949 1.87692
    IM4K4:PPM:FWM:VAL_RBV 2023-08-22 10:21:50.375985 1.74212

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-1248

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tongju12 tongju12 merged commit 27c4924 into pcdshub:master Aug 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants