Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding targets #134

Merged
merged 4 commits into from
Oct 14, 2024
Merged

adding targets #134

merged 4 commits into from
Oct 14, 2024

Conversation

tongju12
Copy link
Contributor

@tongju12 tongju12 commented Oct 3, 2024

PA1K4:PF was added into 7 targets and I update for all positions and PMPS feature
Update new target positions for SP1K4-ATT and recover target number from 3 to 5

Hard coated all targets positions and PMPS feature
Modify SP1K4-ATT new paddle positions and target number recovering back to 5

Motivation and Context

new devices with all new targets installed in beamline.
Scientists have a new temporary paddle to swap in SP1K4-ATT

How Has This Been Tested?

Scientists already test all of them for two devices.

Where Has This Been Documented?

https://jira.slac.stanford.edu/browse/ECS-4824

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@tongju12 tongju12 requested a review from nrwslac October 11, 2024 15:28
Copy link
Contributor

@nrwslac nrwslac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues here. lgtm.

@tongju12 tongju12 marked this pull request as ready for review October 14, 2024 18:34
@tongju12 tongju12 merged commit c579e77 into pcdshub:master Oct 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants