changing at2k4 to pa1k4-pf #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like simple name change. Does this build without errors? @tongju12. If so, could you update the how this was tested by including that. |
|
Nick, I log in with this build and can move any motors without issue. For P1K4-PF, I can move little bit but it is limited by PMPS setup. Currently, this motor hardware is not installed. So it is ok to let it go. I will come back to recheck this motor after hardware is installed. |
|
I think in this case where the hardware names have changed it would be best to do a full activation to ensure that all the names and links restore correctly. |
|
I did Nick. I already activate configuration, log in without any issues and test a little bit already. Otherwise, it will not work. |
nrwslac
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change device at2k4 to pa1k4-pf
change all at2k4 related parts to pa1k4-pf
Motivation and Context
Naming committee asks TMO to use pa1k4-pf instead of at2k4
How Has This Been Tested?
Not yet. Because scientists do not want me to move, the hardware is not ready.
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)