Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing thermocouple linking, adding RTD states to attenuators #74

Merged
merged 9 commits into from
Oct 23, 2024

Conversation

jyotiphy
Copy link
Contributor

@jyotiphy jyotiphy commented Oct 18, 2024

Description

Fixing thermocouple linking
Adding RTD states to solid attenuators
Update cc library to fix some bug related to powermeter code

Motivation and Context

Fixing PLC code to match new library changes

How Has This Been Tested?

Not yet

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

@jyotiphy jyotiphy changed the title Fixing thermocouple linking, adding RTD states to attenuators, cc lib u… Fixing thermocouple linking, adding RTD states to attenuators Oct 18, 2024
ZLLentz
ZLLentz previously approved these changes Oct 18, 2024
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this to solve the known issues related to pmps faults

Copy link
Contributor

@ghalym ghalym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jyotiphy jyotiphy merged commit ae86c43 into pcdshub:master Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants