Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I 960 Generate event-feed.ndjson as part of Results Export Report #961

Merged
merged 1 commit into from
May 7, 2024

Conversation

johnbrvc
Copy link
Collaborator

@johnbrvc johnbrvc commented May 3, 2024

Description of what the PR does

End of contest procedures require the saving of the event-feed.ndjson file in addition to the already saved results.tsv, scoreboard.json and awards.json. The changes here arrange for event-feed.ndjson to be saved as part of the Results Export Report.

Issue which the PR addresses

Fixes #960

Environment in which the PR was developed (OS,IDE, Java version, etc.)

Windows 11
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

  1. Load up any contest
  2. From the pc2server, go to the Reports tab.
  3. Choose the Results Export Files report
  4. Press "Export Report Contents"
  5. Notice that event-feed.ndjson is now generated as part of the report.
image

End of contest procedures require the saving of the event-feed.ndjson file in addition to the already saved results.tsv, scoreboard.json and awards.json.  The changes here arrange for event-feed.ndjson to be saved as part of the Results Export Report.
@johnbrvc johnbrvc added this to the 9.11.0 milestone May 3, 2024
@johnbrvc johnbrvc self-assigned this May 3, 2024
Copy link
Collaborator

@SamanwaySadhu SamanwaySadhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only went through changes in code, and they look good to me. I have not run and checked functionality.

@johnbrvc johnbrvc merged commit be78042 into pc2ccs:develop May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create event-feed.ndjson file as part of the Results Export Report
3 participants