i_946 Preserve problem title if no TEX files #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check for existence of problem_statement/problem.en.tex before trying to get the problem name (problemTitle) from it.
troy2914
reviewed
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Add check for existence of
problem_statement/problem.en.texbefore trying to get the problem name (problemTitle) from it.Issue which the PR addresses
Fixes #946
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Windows 11
jdk1.8.0_321
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
problem.yamlfile that has a title property giving the name of the problem.problem_statementfolder.problem.yamlas the problem name.NOTE: I did NOT remove all the typecast's throughout the code. That was Eclipse. I even tried putting them back, but it insisted on removing the redundant typecast's. The REAL code changes are at line 1409 and 1411 - so you can skip the rest and go right there. Also, all the space removals at the end of lines, etc. were a result of eclipse "cleaning up" the code. If you want me to turn that option off, I can do that. Personally, I find it extremely annoying, even for me - it makes finding the real change extremely difficult. I guess a case could be made, that whoever did that originally (added all the spaces at the end of lines, etc.) is the culprit. Nevertheless, it's still bothersome.