i_943 Fix Group tab on Edit Problem #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not enable/disable individual group check boxes. This causes excesseive overhad when checking for the Update button. Instead, enable/disable the entire JCheckboxJList control which CONTAINS the checkboxes. This appears to be the original author's intent. Left some commented-out code with comments to help in code review. Will be removed prior to merging after approved.
Change copyright year for ProblemGroupPane.java
troy2914
approved these changes
Mar 20, 2024
Some code was left in for the code review/approval process. Since the PR was approved, these comments are now gone (but still in the history).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Do not enable/disable individual group check boxes. This causes excesseive overhad when checking for the Update button.
Instead, enable/disable the entire
JCheckBoxJListcontrol which CONTAINS the checkboxes. This appears to be the original author's intent.Left some commented-out code with new comments to help in code review. Will be removed prior to merging after approved.
Issue which the PR addresses
Fixes #943
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Windows 11
jdk1.8.0_321
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
Part 1:
Part 2 (slowness loading):
wfluxor/contests/wf47/systest1) that has lots of groups defined (>20) and problems with lots of test cases and/or big test case files.