I 221 add clarification announcement #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkarakas
force-pushed
the
i_221_add_clarification_announcement
branch
from
059b62c to
6e84743
Compare
Various Bugs Users can also do announcement since they share a pane with the judge. (Major) Groups are not implemented (Major) NullController etc has errors in it but I dont know what they are(Major-Minor) Users receive a response, rather than announcement. (Minor) Buttons are not alligned well (Minor) Hover info can be added (Minor) Copyright are not dated right (Minor)
kkarakas
force-pushed
the
i_221_add_clarification_announcement
branch
from
fd82443 to
72d3827
Compare
kkarakas
changed the title
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
johnbrvc
reviewed
Mar 14, 2024
…y judge, various fixes and various fixes to address comments.
|
Merge conflicts does not appear to have caused any problems. |
johnbrvc
approved these changes
Nov 23, 2024
SamanwaySadhu
suggested changes
Nov 23, 2024
| @@ -472,6 +473,7 @@ public Response clarifications(@ApiParam(value="token used by logged in users to | |||
|
|
|||
| //return to the team only those clars that came from the team, or from the judges | |||
| if(clar.getTeam().getLoginName().equalsIgnoreCase(userInformation.getMyClient().getLoginName()) || isJudge || clar.isSendToAll()) { | |||
| //TODO must also include clars directed to here from group | |||
There was a problem hiding this comment.
Is this going to be a part of separate issue?
src/edu/csus/ecs/pc2/api/implementation/ClarificationImplementation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Judge can now send announcement clarification to all teams,groups,certain teams with a single button. Their announcement will be displayed as announcement in "All clarifications" tab with correct destinations. In future, how it appears to WTI should be considered.
Issue which the PR addresses
fixes #221
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Windows 11, Eclipse 2021-12 R, JDK 8u381 (1.8)
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
From judge, go to generate clarification, toggle generate announcement. Observe that the text on button changes, title changes (hidden under checkbox right now), various buttons come. When announcement is sent all users receive a clarification without question.
Judge can also sent clarification without question to groups and some users from the same tab.
Observe that Judges and teams display all clarifications tab correctly. Judges now have the status of ANNOUNCED and shows all the teams,groups it sent.