Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i_1003 Use CLICSScoreboard instead of ScoreboardJson #1004

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

johnbrvc
Copy link
Collaborator

@johnbrvc johnbrvc commented Sep 3, 2024

Description of what the PR does

For the Results Export Files report, use the newer CLICSScoreboardJson class which includes the correct time property for each problem, as well as the correct shortname (instead of the element id).

Issue which the PR addresses

Fixes #1003

Environment in which the PR was developed (OS,IDE, Java version, etc.)

Windows 11
java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

  1. On a completed contest, generate the "Results Export Files" report.
  2. View the scoreboard.json file.
  3. Look for the correct short name for a team's problems as well as a non-zero time property, if the problem was solved.

@johnbrvc johnbrvc added this to the 9.11.0 milestone Sep 3, 2024
@johnbrvc johnbrvc self-assigned this Sep 3, 2024
Copy link
Contributor

@troy2914 troy2914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@johnbrvc johnbrvc merged commit 52f7697 into pc2ccs:develop Sep 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results Export Files report should use CLICSScoreboard instead of ScoreboardJson
2 participants