-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I983 custom honors solved count #1001
Merged
johnbrvc
merged 14 commits into
pc2ccs:develop
from
SamanwaySadhu:I983_custom_honors_solved_count
Dec 10, 2024
Merged
I983 custom honors solved count #1001
johnbrvc
merged 14 commits into
pc2ccs:develop
from
SamanwaySadhu:I983_custom_honors_solved_count
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. If WF style rankings then Highest Honors, High Honors and Honors are assigned, based on new "Bill" rules. 2. Standings Record Comparator now uses case insensitive comparator for account names. 3. Account Name Comparator is updated to make accent insensitive.
…r compare which was not perfect
1. Removed wf2017 from test data as it was not compliant with Bill's new rules 2. Added wf47 data and new results.tsv generated by DOMjudge compliant with Bill's new rules 3. Updated algorithm to consider 0 solved problems as "Honorable" no matter what 4. For non-WFGroups consider only isHonor (equivalent to isRanked) 5. Updated expected results of test cases for 0 solved problems cases.
…ors with multiple solvd problems
…lues\n2) Update Reload Frame to handle Enabling/Disabling of Swing Utilities Correctly.
johnbrvc
reviewed
Aug 24, 2024
johnbrvc
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes made.
This comment was marked as resolved.
This comment was marked as resolved.
kkarakas
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the code it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Add option to customize the minimum number of problems solved to get Highest Honors, High Honors or Honors through the Finalize Pane in case we're using WF style rankings.
Issue which the PR addresses
Fixes #983
Environment in which the PR was developed (OS, IDE, Java version, etc.)
Windows 10, Eclipse 2021-12 R, JDK 8u381 (1.8), C++ 13.2.0
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
profiles
folder andprofiles.properties
files.Run Contest
andFinalize
tab to toggle between WF group rankings checkbox.Update
.View
button to check if changes take effect.