Ranged Integers #66
Ranged Integers #66
Conversation
| BinaryOperator::Lesser => ( | ||
| (self.new_int_type(), self.new_int_type()), | ||
| BOOL_CONCRETE_TYPE, | ||
| ), |
There was a problem hiding this comment.
I wonder, it's not something that should concern us too badly, but maybe the boolean comparison ops should unify(left, right). Maybe, maybe not.
| } | ||
|
|
||
| impl BinaryOpTypecheckConstraint { | ||
| fn new( |
| impl DelayedConstraint<InstantiationContext<'_, '_>> for BinaryOpTypecheckConstraint { | ||
| fn try_apply(&mut self, context: &mut InstantiationContext<'_, '_>) -> DelayedConstraintStatus { | ||
| if context.wires[self.left].typ.contains_unknown() | ||
| || context.wires[self.right].typ.contains_unknown() |
There was a problem hiding this comment.
You must call typ.fully_substitute() before you can call contains_unknown(). unify doesn't actually change the ConcreteType objects, it only changes the state of the TypeUnifier by adding to the substitution list
| } | ||
| let left_complete_type = context.wires[self.left] | ||
| .typ | ||
| .try_fully_substitute(&context.type_substitutor) |
There was a problem hiding this comment.
Oh, I see you're already doing a try_fully_substitute here. Then returning NoProgress should be when this returns None.
| fn report_could_not_resolve_error(&self, context: &InstantiationContext<'_, '_>) { | ||
| let message = format!( | ||
| "Failed to Typecheck {:?} = {:?} {} {:?}", | ||
| self.out, self.right, self.op, self.left |
There was a problem hiding this comment.
You should fully_substitute these, and ignore the return code. Otherwise this will just print type_variable_xyz
| ConcreteType::Named(global_ref) => { | ||
| f.write_str(&self.linker_types[global_ref.id].link_info.get_full_name())?; | ||
| for template_arg in global_ref.template_args.iter() { | ||
| write!(f, "{}", template_arg.1.display(self.linker_types))?; |
There was a problem hiding this comment.
You should add the field names. Actually, there is a function that does this already: pretty_print_concrete_instance
There was a problem hiding this comment.
Where do I get the &LinkInfo from? Should it be added to the display proxy?
There was a problem hiding this comment.
&self.linker_types[global_ref.id].link_info
| pub fn try_fully_substitute( | ||
| &self, | ||
| substitutor: &TypeSubstitutor<Self, ConcreteTypeVariableIDMarker>, | ||
| ) -> Option<Self> { |
There was a problem hiding this comment.
This implementation is incorrect. contains_unknown just checks this ConcreteType object, not the substituted version. You should base your return value on the boolean returned by fully_substitute
src/typing/type_inference.rs
Outdated
| assert!(*na == *nb); | ||
| UnifyResult::Success | ||
| assert!(na.template_args.len() == nb.template_args.len()); | ||
| zip(na.template_args.iter(), nb.template_args.iter()) |
There was a problem hiding this comment.
Use crate::alloc::zip_eq here
| } | ||
| }; | ||
| let mut template_args: FlatAlloc<ConcreteType, TemplateIDMarker> = FlatAlloc::new(); | ||
| template_args.alloc(ConcreteType::new_int(out_size)); |
There was a problem hiding this comment.
Could be combined with ConcreteType::new_int_type
src/instantiation/mod.rs
Outdated
| @@ -426,3 +426,9 @@ fn perform_instantiation( | |||
|
|
|||
| context.extract() | |||
| } | |||
|
|
|||
| impl InstantiationContext<'_, '_> { | |||
| pub fn new_int_type(&self) -> ConcreteType { | |||
|
Add test cases |
|
Add types to in code values / constants |
|
Cast module |
Close #28