Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose a config to adjust the StdBy pool size (if required) #387

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

venkatsridhar95
Copy link
Collaborator

By default, the fallback pool size is equal to the primary pool size.

Copy link
Collaborator

@rasamala83 rasamala83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the minimal value better to be higher than 1? single-worker pool might potentially cause saturation features to be triggered too easily (not meaningfully helpful).

@venkatsridhar95
Copy link
Collaborator Author

@shtiencode A minimum value of 1 will be triggered only when taf_children_pct is below 0 or when the taf_children_pct of the existing worker pool size is too low.

@shtiencode
Copy link
Collaborator

@shtiencode A minimum value of 1 will be triggered only when taf_children_pct is below 0 or when the taf_children_pct of the existing worker pool size is too low.

@venkatsridhar95 Yes, you could also reach 1 and it would be less meaningful. Arguably though, I can see existing readonly pct also applied same logic (with different purpose though). It looks ok to me but suggest higher default value may prevent abusive configuration.
num = num * gAppConfig.TafChildrenPct / 100
if num == 0 {
num = 1

Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a suggestion in comment for prevention of abusive setting that we can review later as issue.

@venkatsridhar95 venkatsridhar95 merged commit 1124f4b into paypal:main Nov 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants