fix(richtext-lexical): incorrect UploadData types #11288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
reviewed
Feb 19, 2025
packages/richtext-lexical/src/features/upload/server/nodes/UploadNode.tsx
Show resolved
Hide resolved
GermanJablo
reviewed
Feb 19, 2025
packages/richtext-lexical/src/features/upload/server/nodes/UploadNode.tsx
Show resolved
Hide resolved
GermanJablo
reviewed
Feb 19, 2025
| @@ -8,34 +8,29 @@ export const UploadJSXConverter: JSXConverters<SerializedUploadNode> = { | |||
| upload: ({ node }) => { | |||
| // TO-DO (v4): SerializedUploadNode should use UploadData_P4 | |||
| const uploadDocument = node as UploadDataImproved | |||
| if (typeof uploadDocument.value !== 'object') { | |||
| if (typeof uploadDocument?.value !== 'object') { | |||
There was a problem hiding this comment.
I guess ts was asking for optional chaining here? any reason why it is needed now? afaik value should be defined
GermanJablo
reviewed
Feb 19, 2025
packages/richtext-lexical/src/features/upload/server/nodes/UploadNode.tsx
Show resolved
Hide resolved
GermanJablo
reviewed
Feb 19, 2025
packages/richtext-lexical/src/exports/react/components/RichText/converter/converters/upload.tsx
Show resolved
Hide resolved
|
🚀 This is included in version v3.25.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
UploadDatatype that was weakened in a previous PR, causing a breaking change. It also improves the newly addedUploadDataImprovedtype by bringing back its support for generated types and using theUploadCollectionSlugtype helper to restrict collection slugs to upload-enabled collections.