fix: process images for resizing more reliably #11281
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we did image resizing in parallel. Meaning if you have 10 different sizes, the machine would process all those at the same time, which potentially can lead to issues with memory, increased CPU usage and unexpected crashes, as the image resizing process is expensive unless you offload it to a different server, which we don't support.
This PR changes to do that sequentially, which could be slower, but more reliable overall which is more important.
Additionally, modifies this call:
to
As we don't really need to await it or block the thread with
unlinkSync
.Fixes #8592