chore: revert add typescript-strict-plugin to the payload package for incremental file-by-file migration [skip lint] #11226
+13
−402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11133
Unfortunately,
typescript-eslint
cannot communicate withtypescript-strict-plugin
, leading to desynchronization. This desynchronization can cause confusing errors. For example, TypeScript may request a non-null assertion, while ESLint deems it unnecessary and removes it on save via autofix.Disabling
typescript-eslint
during the migration feels like a cure worse than the disease.Another alternative I thought of is to use two tsconfig files: the main one and another for already migrated files in strict mode, but VSCode has no way to tell intellisense to use something other than
tsconfig.json
, such astsconfig.typecheck.json
. This would prevent IDE error detection, leaving us to discover issues in CI after PR failures—a potentially frustrating experience.We may need to handle the migration the old-school way: make tsconfig strict, fix errors, and push changes without committing the tsconfig modifications until all errors are fixed. As I said in the original PR, the problem with that strategy is that new PRs may still introduce errors into files that were already fixed, but it is what it is.
Allocating sufficient time to the migration could help mitigate this issue. But that's something we'll have to weigh in our order of priorities.