FISH-9802 Fix EJB Failures in Authorization 3.0 TCK #6998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrappy implementation, taking code from GlassFish. While this fixes the EJB tests from the JACC TCK, it's not ideal as we're still duplicating a lot of code from Exousia. At this point we're creating a AuthorizationService instance so that it gets registered in the DefaultPolicyContextHandler, but not actually using it for authorization Signed-off-by: Andrew Pielage <[email protected]>
Signed-off-by: Andrew Pielage <[email protected]>
GlassFish have a separate class for the methods imported in the previous commit, so for the sake of clarity I'm realigning them here (though swapping out the GlassFish name to Payara)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the EJB authorization tests in the Authorization TCK.
This is intended as a stop-gap solution for now, as I believe this class (and all surrounding JACC code) needs some heavy rewrites - we're only "half" using Exousia in the current state, duplicating a lot of code and so not always using Exousia itself for authorization.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Ran the Authorization TCK, didn't spot any new failures (app-custom-policy2 tests fails regardless)
Ran all currently passing TCKs, no new failures (jsp runner is currently broken - ignore. #WorksOnMyMachine): https://jenkins.payara.fish/view/Build/job/JakartaEE-11-TCK/48/
Testing Environment
OpenSUSE WSL, Maven 3.9.9, Zulu JDK 21.0.4
Documentation
N/A
Notes for Reviewers
None