Fix invalid iOS device token decoding before sending to Intercom #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use this non-official branch to integrate Intercom into a Flutter project I'm working on and the push notification was still not working on iOS as expected, after some investigations, I found the
sendTokenToIntercommethod call was implemented twice (I believe it might be a conflict resolution issue) and the 1st of them had an incorrect way of decodingtokenargument fromNSStringintoNSDataand we end up sending an invalid token to Intercom.Additionally, I enabled Intercom logging and removed the explicit Intercom 7.1.0 pod dependency.