Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config option to ignore files based on Unix shell-style wildcard pattern matching #23

Merged
merged 4 commits into from
May 5, 2024

Conversation

nfelt14
Copy link
Contributor

@nfelt14 nfelt14 commented Apr 30, 2024

This adds the skip_file_globs config option to enable skipping files based on a Unix shell-style glob. This also updates the skip_files config option to treat file paths as OS-agnostic.

fixes #21
resolves: #20

…dcard pattern matching

Also updates `skip_files` to treat file paths as OS-agnostic.

Issue pawamoy#21: pawamoy#21
Issue pawamoy#20: pawamoy#20
@nfelt14
Copy link
Contributor Author

nfelt14 commented Apr 30, 2024

@pawamoy let me know if there are any changes necessary in this PR.

Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

.gitignore Outdated Show resolved Hide resolved
src/mkdocs_spellcheck/plugin.py Outdated Show resolved Hide resolved
src/mkdocs_spellcheck/plugin.py Outdated Show resolved Hide resolved
@nfelt14
Copy link
Contributor Author

nfelt14 commented May 3, 2024

Thanks for the PR!

You are welcome. Let me know if there are any other changes needed.

@nfelt14
Copy link
Contributor Author

nfelt14 commented May 4, 2024

Thanks for the PR!

You are welcome. Let me know if there are any other changes needed.

@pawamoy, I think this is ready now.

@pawamoy
Copy link
Owner

pawamoy commented May 4, 2024

Yep, thanks for the notification, I'll review this tomorrow 🙂

Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK LGTM, thanks a lot!

@pawamoy pawamoy merged commit 2ae097d into pawamoy:main May 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: skip_files is not OS-agnostic feature: Ability to skip files based on globs or regex
2 participants