Fix websocket match condition

paulscherrerinstitute · Aug 27, 2024 · d6bf7d3 · d6bf7d3
1 parent bc69078
commit d6bf7d3
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/sci-log-db/src/__tests__/unit/websocket.utils.ts b/sci-log-db/src/__tests__/unit/websocket.utils.ts
@@ -46,6 +46,24 @@ describe('Websocket unit tests', function (this: Suite) {
       ],
       expected: false,
     },
+    {
+      input: [
+        {tags: ['b', 'p'], snippetType: 'aType'},
+        {filter: {snippetType: []}},
+      ],
+      expected: true,
+    },
+    {
+      input: [{tags: ['b', 'p'], snippetType: 'aType'}, {filter: {tags: []}}],
+      expected: true,
+    },
+    {
+      input: [
+        {tags: ['b', 'p'], snippetType: 'aType'},
+        {filter: {tags: [], snippetType: []}},
+      ],
+      expected: true,
+    },
   ].forEach((t, i) => {
     it(`Should test matchesFilterSettings ${i}`, () => {
       expect(

diff --git a/sci-log-db/src/utils/websocket.ts b/sci-log-db/src/utils/websocket.ts
@@ -252,9 +252,11 @@ export function matchesFilterSettings(
 ): boolean {
   const tagCondition =
     !config.filter?.tags ||
-    config.filter?.tags?.some(tag => snippet.tags?.includes(tag));
+    config.filter.tags.length === 0 ||
+    config.filter.tags.some(tag => snippet.tags?.includes(tag));
   const snippetTypeCondition =
     !config.filter?.snippetType ||
-    config.filter?.snippetType?.includes(snippet.snippetType);
+    config.filter.snippetType.length === 0 ||
+    config.filter.snippetType.includes(snippet.snippetType);
   return tagCondition && snippetTypeCondition;
 }