Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to highlight Number constructor whitspace handling deficiencies #368

Closed
wants to merge 1 commit into from

Conversation

Xotic750
Copy link
Contributor

@Xotic750 Xotic750 commented Nov 2, 2015

Number(' 2 ') === 2
So just like with trim, different environments handle internal trimming differently and inconsistently.

@ljharb
Copy link
Collaborator

ljharb commented Nov 2, 2015

Related to #354

@Xotic750 Xotic750 changed the title Add tests to highlight trim deficiencies. Add tests to highlight Number constructor whitspace handling deficiencies Nov 2, 2015
@ljharb ljharb closed this in 740822a Nov 2, 2015
@ljharb
Copy link
Collaborator

ljharb commented Nov 2, 2015

Thanks, fixed.

ljharb added a commit to ljharb/es-abstract that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants