Add methods to set and get custom data for juice agents #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented juice_agent_set_data to allow users to attach custom data to a juice agent. - Implemented juice_agent_get_data to retrieve the custom data attached to a juice agent. - Updated juice_agent_t structure to include a user_ptr for storing custom data. - Added tests to validate the functionality of the new methods. These changes enable each juice agent to have its own custom data, enhancing flexibility and usability.
| /* This is a custom field that can be used to store user data for the agent. | ||
| * Use the juice_agent_set_data and juice_agent_get_data methods to store and retrieve the data. | ||
| */ | ||
| void* user_ptr; |
There was a problem hiding this comment.
What is the difference with the existing user_ptr in juice_config_t?
There was a problem hiding this comment.
Hey, I wanted each agent to have its own (unique) data.
My current implementation uses the same juice_config_t for all the agents.
I just realised that if I create multiple instances of juice_config_t, each having its own unique data, then each agent will also have its own user pointer.
I'll close the PR, thanks
There was a problem hiding this comment.
Oh OK, the config is actually copied for each agent, so you can change it between calls to juice_create(), it won't interfere with already-created agents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable each juice agent to have its own custom data, enhancing flexibility and usability.