fix: display warnings even if no errors #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denar90 Do you know when that fix will be released? |
|
Sorry, I didn't mention, it was released right after merging your PR. |
|
Hmmm... No it's not ^^ The last version is the 4.0.0, released 22 days ago, or that PR has been merged 10 days ago. |
|
Strange that you don't see new version, because on npm it's 4.0.1 - https://www.npmjs.com/package/pwmetrics |
|
I think the confusion here because I didn't create a tag... |
Damned... I should have looked at NPM too 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently no warnings are displayed until there is at least one error. That PR fixes that.