Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

add missing arguments to CommentElement::create() #208

Conversation

websupporter
Copy link
Contributor

closes #207

@CLAassistant
Copy link

CLAassistant commented May 11, 2018

CLA assistant check
All committers have signed the CLA.

@paulgibbs
Copy link
Owner

Hi @websupporter

Thanks for trying WordHat, and sending over a PR! I'll look at it soon.
At a glance, it looks fine, although I wonder how we missed those parameters when we had the others. 🤔

@paulgibbs
Copy link
Owner

We haven't forgotten this. Waiting to see how #205 pans out (and get a feeling how of the time), plus i've some holiday days coming up, so will probably be 2 weeks before I can get to this.

@websupporter
Copy link
Contributor Author

No stress. Thanks for your feedback 😄

@paulgibbs paulgibbs merged commit 1fbf5ab into paulgibbs:master Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arguments missing in CommentElement::create()
3 participants