fix redirect after poll

paulgessinger · Dec 4, 2023 · ac73d9d · ac73d9d
1 parent 516ece1
commit ac73d9d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/herald/templates/loading.html b/src/herald/templates/loading.html
@@ -25,7 +25,7 @@
 					</div>
 				</div>
 
-			<div hx-get="{{ url_for('view_poll', owner=owner, repo=repo, artifact_id=artifact_id) }}"
+			<div hx-get="{{ url_for('view_poll', owner=owner, repo=repo, artifact_id=artifact_id, file=file) }}"
 					hx-trigger="load"
 					hx-swap="outerHTML" style="display:none;">
 			</div>

diff --git a/src/herald/web.py b/src/herald/web.py
@@ -282,15 +282,15 @@ async def async_get_file() -> Tuple[IO[bytes], str]:
         #  abort(404)
 
     @app.route("/poll/<owner>/<repo>/<int:artifact_id>")
-    @app.route("/view/<owner>/<repo>/<int:artifact_id>/<path:file>")
-    async def view_poll(owner: str, repo: str, artifact_id: int, path: str = ""):
+    @app.route("/poll/<owner>/<repo>/<int:artifact_id>/<path:file>")
+    async def view_poll(owner: str, repo: str, artifact_id: int, file: str = ""):
         is_cached = gh.is_artifact_cached(f"{owner}/{repo}", artifact_id)
         logger.debug(
             "Polling for %s/%s #%d => %s, is cached: %s",
             owner,
             repo,
             artifact_id,
-            path,
+            file,
             is_cached,
         )
 
@@ -304,11 +304,13 @@ async def view_poll(owner: str, repo: str, artifact_id: int, path: str = ""):
                         owner=owner,
                         repo=repo,
                         artifact_id=artifact_id,
-                        file=path,
+                        file=file,
                     )
                 },
             )
-        poll_url = url_for("view_poll", owner=owner, repo=repo, artifact_id=artifact_id)
+        poll_url = url_for(
+            "view_poll", owner=owner, repo=repo, artifact_id=artifact_id, file=file
+        )
 
         return f"""
             <div hx-get="{poll_url}" hx-trigger="load delay:2s" hx-swap="outerHTML" style="display:none;"></div>