Widespread spec failure when not using memcache #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment out the line specifying the array of memcache servers from the spec_helper so the tests will pass by default for everyone, including people who don't have memcache installed. Added a comment before this so users know this setting exists if they do have memcache installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've pulled down the repository and run the specs, but I get 53 failures since I'm not using memcache.
My steps:
See 53 of the 79 examples fail because of the following error:
From what I can tell, the error is at gitmodel.rb:102 because spec_helper.rb:21 sets memcache_servers to ['localhost']. So if I don't actually have a memcache server running, this will cause the errors in later tests.
In order to get the specs passing by default for everyone, I've commented out this line. Added another comment so people know they can use this line if they have memcache installed.