Updated to Python 3.6 #52
Conversation
|
Follow-Up PR potential commits: |
|
Thanks, Michael! I've been using this for a few weeks now. I can confirm that the "basic" tutorial (the one with the wing function) is running perfectly for me on a Windows machine running python 3.6. I also converted some of my own personal research notebooks that were using the old active subspace library to py3.6 using this package, and again, those ran perfectly on Windows. I can also confirm that one of my notebooks runs on Mac, py3.6 as well. If I'm not mistaken, that means we have success in py3.6 for Windows, Mac, and Linux. |
|
@paulcon is there anything I'm missing from this PR that is preventing it from merge? |
|
@jordanrhall and @mathematicalmichael would mind if I ask what could be the reason I am getting this error AttributeError: module 'active_subspaces' has no attribute 'utils'. |
|
@shahrozkhan66 how are you installing it and what code are you running to produce that output? |
|
Hello,
This error generally means that your "active_subspaces" folder isn't saved in a place where your Python kernel can access it. An easy fix will (probably) be simply copying/pasting the entire active_subspaces folder into the working directory that contains the notebook/script you are trying to use the ac commands. You could also just clone a fresh copy of active_subspaces into that working directory.
Best, Jordan
…________________________________
From: Michael Pilosov <[email protected]>
Sent: Tuesday, April 2, 2019 10:07 AM
To: paulcon/active_subspaces
Cc: Hall, Jordan R; Mention
Subject: Re: [paulcon/active_subspaces] Updated to Python 3.6 (#52)
@shahrozkhan66<https://github.com/shahrozkhan66> how are you installing it and what code are you running to produce that output?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#52 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AUM2TVFW6OKi4osOXwuUG_DzfvEkGwn4ks5vc4AsgaJpZM4aCahJ>.
|
|
ah, in that case, running Try running your code in the environment that spawns up here: |
|
Is there anybody able to merge this PR? It would be of great interest the python 3 compatibility. |
|
Yeah I’m not sure what the story is. This is backwards compatible with Python 2, which is reaching end of life in a couple months anyway. Fortunately you can still use it, just clone my fork and install from source. Been a while since I’ve done this so let me know if anything needs addressing. |
Test on 3.7 and 3.8, quotes unnecessary
Update .travis.yml
|
looks like scipy 2.0 (default install) no longer supports some of the modules imported by this library. Another PR is open for fixing this by version-locking scipy to 1.2.2 and will be added on to here soon. |
|
updating installation steps. conda on python 3.8 installs matplotlib 3.0, which appears to be an issue. |
trying a few things, including switching to `nosetests` syntax
switch to pytest
remove pytest install in hopes that pip catches it.
scipy doesn't work for 2.0
pytest and agg backend
back to nosetests
back to nosetests
looks like not having conda install pip was an issue (the pip that was being called was the "wrong one") Let's try to do this _without_ conda. Travis has its own system python versions cached anyway, so it should expedite tests a bit too.
Update CI pipeline
tests pass, only matplotlib warnings remain. Backwards compatible with Python 2.7.
Most of the fixes had to do with the default type being Float instead of Int.