Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(190): Inject dependencies with Koin #197

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

enthuan
Copy link
Collaborator

@enthuan enthuan commented Mar 13, 2024

Use the Koin framework to handle the project dependencies.

  • Added a DI module with a single entry point to inject everything
  • On iOS, use a container to get injected classes
  • Added some viewModels to simplify injection
  • Added some use cases for uniformity.

The use cases could be maybe removed in the future because they are almost bypassing calls

Closes #190

@enthuan enthuan requested review from BoD and martinbonnin March 13, 2024 14:36
@enthuan
Copy link
Collaborator Author

enthuan commented Mar 13, 2024

It seems that the bookmark feature is broken on the detail screen on iOS. I need to improve the getAgenda usecase or to combine the bookmarks on the shared layer.
➕ the sessions are not yet migrated to KMP on iOS

@enthuan enthuan merged commit 238d5a1 into paug:main Mar 14, 2024
1 check passed
@enthuan enthuan deleted the feat/190 branch March 14, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some kind of dependency injection
1 participant