Add sqlite-vec support #906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,12 @@ class VersionError < ScriptError; end | |||
| # @raise [VersionError] If the gem is installed, but the version does not meet the requirements | |||
| # | |||
| def depends_on(gem_name, req: true) | |||
| gem(gem_name) # require the gem | |||
| if gem_name == "sqlite_vec" | |||
There was a problem hiding this comment.
@CarlQLange Why is this if/else statement needed? Isn't the gem version what gets required?
There was a problem hiding this comment.
Woof, I have no memory of this. I think it was something to do with using the gem locally from something else. Sorry, I pretty much have no idea what I was doing back then!
| # @return [Array<Integer>] The ids of the added texts | ||
| def add_texts(texts:, ids: nil) | ||
| if ids.nil? || ids.empty? | ||
| max_rowid = @db.execute("SELECT MAX(rowid) FROM #{table_name}").first.first || 0 |
There was a problem hiding this comment.
Doesn't the rowid auto increment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some support for sqlite-vec.
Unfortunately I am brand new to Ruby so there was plenty of help from professor ChatGPT, so I would strongly recommend a close inspection to make sure I got things right. Having said that, the example script appears to work on my machine. I hope if nothing else that this may be a useful starting point to add SQLite support to this library.