fix: resolve csv column off by one error

patsier-cms · May 21, 2024 · f20bae8 · f20bae8
1 parent eca314c
commit f20bae8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/versions/common/csv.ts b/src/versions/common/csv.ts
@@ -47,7 +47,7 @@ export function csvColumnName(column: number): string {
   if (column < ASCII_UPPERCASE.length) return ASCII_UPPERCASE[column]
 
   return (
-    ASCII_UPPERCASE[Math.floor(column / ASCII_UPPERCASE.length)] +
+    ASCII_UPPERCASE[Math.floor(column / ASCII_UPPERCASE.length) - 1] +
     csvColumnName(column % ASCII_UPPERCASE.length)
   )
 }

diff --git a/test/common/csv.spec.ts b/test/common/csv.spec.ts
@@ -0,0 +1,7 @@
+import test from "ava"
+import { csvColumnName } from "../../src/versions/common/csv.js"
+
+test("csvColumnName", (t) => {
+  t.is(csvColumnName(0), "A")
+  t.is(csvColumnName(26), "AA")
+})