Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump up precommit hooks #837

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

knyazer
Copy link
Contributor

@knyazer knyazer commented Sep 7, 2024

Also added toml filetype to ruff scanning, since ruff has some checks for the pyproject.toml structure: RUF200

Ruff started to introduce support for pyproject.toml linting
@knyazer knyazer marked this pull request as draft September 7, 2024 19:31
@knyazer
Copy link
Contributor Author

knyazer commented Sep 7, 2024

Do you think it makes sense to wait for jax-ml/jax#23492 to get merged, so that we can use one less # pyright: ignore? I don't think it matters a ton :)

@knyazer knyazer marked this pull request as ready for review September 7, 2024 20:46
Copy link
Owner

@patrick-kidger patrick-kidger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings about the pyright-ignores, happy to merge without that.

equinox/nn/_conv.py Show resolved Hide resolved
@knyazer knyazer marked this pull request as draft September 8, 2024 13:04
@knyazer
Copy link
Contributor Author

knyazer commented Sep 8, 2024

Fixed the typos, while I'm on it 😉

@knyazer knyazer marked this pull request as ready for review September 8, 2024 13:16
@patrick-kidger patrick-kidger merged commit 97ac55a into patrick-kidger:main Sep 9, 2024
2 checks passed
@patrick-kidger
Copy link
Owner

patrick-kidger commented Sep 9, 2024

This LGTM -- merged! Thank you for all of the (many, many) fixes.

Gosh, I like writing 'argments' instead of 'arguments'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants