Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new IntelliJ Gradle Plugin #95

Closed
wants to merge 5 commits into from

Conversation

DeKaN
Copy link
Contributor

@DeKaN DeKaN commented Sep 29, 2024

The first step for #92

@patou
Copy link
Owner

patou commented Sep 29, 2024

The first step for #92

Thanks, you followed the guide migration ?
https://plugins.jetbrains.com/docs/intellij/tools-intellij-platform-gradle-plugin-migration.html

@DeKaN
Copy link
Contributor Author

DeKaN commented Sep 29, 2024

Yes, I did

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@43f8e2c). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             master     #95   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?      12           
  Lines             ?     290           
  Branches          ?      49           
========================================
  Hits              ?       0           
  Misses            ?     290           
  Partials          ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeKaN
Copy link
Contributor Author

DeKaN commented Oct 2, 2024

@patou Looks like Qodana should be updated, but I'm not sure - can't see its logs

@patou
Copy link
Owner

patou commented Oct 2, 2024

Thanks, I finish the corrections in this PR : #96

@pboling
Copy link
Contributor

pboling commented Oct 2, 2024

Will this result in the setting of "use unicode" being saved with the other plugins' settings in the JetBrains cloud, so they sync across projects?

@patou
Copy link
Owner

patou commented Oct 21, 2024

Thanks @DeKaN for your help, the new version is now live.

@patou patou closed this Oct 21, 2024
@pboling
Copy link
Contributor

pboling commented Oct 22, 2024

@patou Will this result in the setting of "use unicode" being saved with the other plugins' settings in the JetBrains cloud, so they sync across projects?

@patou
Copy link
Owner

patou commented Oct 23, 2024

@patou Will this result in the setting of "use unicode" being saved with the other plugins' settings in the JetBrains cloud, so they sync across projects?

Hello, This update is just for update the gradle plugin. The settings page is storred in the project file. I don't find how to change this without recreate a new global setting page, and how to migrate setting for currents users.
I had no time to work on it now, but open for contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants