Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to add app link #844

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update README.md to add app link #844

merged 2 commits into from
Sep 18, 2024

Conversation

patched-admin
Copy link
Contributor

No description provided.

minor fixes
@patched-admin
Copy link
Contributor Author

The pull request review highlights three major points: Firstly, it stresses the importance of verifying the security and legitimacy of the newly added external link https://app.patched.codes/signin in the README.md to prevent phishing or redirection attacks. Secondly, it notes a potential security risk introduced by changing the client_base_url from HTTPS to HTTP, warning that using unencrypted HTTP in production could expose vulnerabilities, and suggests clarifying if this change is solely for local development purposes. Lastly, it acknowledges the change from Llama-3 to Llama-3.1 in the Patchwork Assistant link and confirms its validity, assuming it is an intentional version update.


  • File changed: README.md
    1. The added app link https://app.patched.codes/signin in the README.md introduces an external link. Ensure this link is secure and verified to prevent potential phishing or redirection attacks.
  1. The modification client_base_url=http://localhost:8080/v1 changes the URL scheme from HTTPS to HTTP. This may introduce security vulnerabilities if developers use this in production since HTTP is not encrypted and can be intercepted. If the change is intended for local development, it's essential to make a note of that in the documentation.
  2. The change from Llama-3 to Llama-3.1 in the Patchwork Assistant link looks valid, assuming this is an intentional update to specify the new version.

@codelion codelion merged commit 4bb02b6 into main Sep 18, 2024
5 checks passed
@codelion codelion deleted the patched-add-app-link branch September 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants