Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic support for multiple nullifiers, rotating keys #3247

Merged
merged 16 commits into from
Feb 24, 2025
Merged

feat: basic support for multiple nullifiers, rotating keys #3247

merged 16 commits into from
Feb 24, 2025

Conversation

lucianHymer
Copy link
Collaborator

fixes #3187

@lucianHymer lucianHymer mentioned this pull request Feb 10, 2025
Closed
@lucianHymer lucianHymer changed the title feat: added Nullifier Generators feat: basic support for multiple nullifiers, rotating keys Feb 10, 2025
@lucianHymer lucianHymer force-pushed the 3187-multi-keys branch 4 times, most recently from d93e6a2 to 7904609 Compare February 11, 2025 15:29
@lucianHymer lucianHymer marked this pull request as ready for review February 12, 2025 11:53
nutrina
nutrina reviewed Feb 17, 2025
View reviewed changes
@lucianHymer @nutrina
feat: added Nullifier Generators
d6253d0
@lucianHymer @nutrina
feat(identity): added mishti nullifier generator
8c5eafc
@lucianHymer @nutrina
chore: fixed existing tests
e708ab8
@lucianHymer @nutrina
test: added mishti nullifier test
40b3128
@lucianHymer @nutrina
test: fix ceramic integration tests
fe9cbd3
@lucianHymer @nutrina
feat(identity): added key manager function
4c5fe4d
@lucianHymer @nutrina
feat(identity): using key rotation in credentials
4e31ef1
@lucianHymer @nutrina
chore: updated getIssuerKey => getIssuerInfo, refactored keyManager
1dfa1c9
@lucianHymer @nutrina
chore: updating ban check to work with new format
cdee3ee
@lucianHymer @nutrina
feat(identity): added ignorable errors when generating nullifiers
add82ae
@lucianHymer @nutrina
feat(identity): ignore mishti errors, rename mishti -> human network
4ba900a
@lucianHymer @nutrina
feat(identity): added execution limiting to nullifiers
afb8dba
@lucianHymer @nutrina
feat: feature flagging multiple nullifiers
2c810ab
@lucianHymer @nutrina
chore: rebase fixes
d5aa620
@lucianHymer @nutrina
fix: fix issues with legacy hash format support, added tests
b20034c
nutrina
nutrina approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@nutrina nutrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nutrina nutrina merged commit ff9e397 into main Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutrina nutrina nutrina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mishti: implement double hashing (iam, embed, infra)
2 participants
@lucianHymer @nutrina